Remove variable syntax for icons#864
Merged
Chng-Zhi-Xuan merged 4 commits intoMay 27, 2019
Merged
Conversation
The files were used as a template to build the iconsMap for using variable syntax to insert icons. Since MarkBind#680, we have shifted to another syntax for inserting icons. We made the decision to depreciate the old variable syntax. Thus it renders the current icon .csv files as obsolete. Let's remove these files as well when depreciating the variable syntax for icons.
The example text refernces :far-file-code:, however the icon rendered was :fas-file-code:. Let's correct this minor documentation mistake.
Chng-Zhi-Xuan
added
the
breakingChange 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Other, please explain: depreciation of old feature.
**Note: This is a breaking change, will have to increment a minor version for next releaseResolves #712
What is the rationale for this request?
Since #680 syntax change, the team has postponed depreciating the old syntax until the academic semester is over. Now that it is summer, the team has the green light to proceed with the depreciation.
What changes did you make? (Give an overview)
glyphicon.csvandfont-awesome.csvfromsrc/assetsgetIconsMapmethod fromSite.js, along with any related constants used.Site.test.jsunit testsicons.mbdfIs there anything you'd like reviewers to focus on?
Testing instructions:
{{ glyphicon-home }}NaNas it doesn't exist.{{ }}with colons: :and the icons should render properly.